use mutex to ensure sequential segment flushed + await on drop#7416
Merged
use mutex to ensure sequential segment flushed + await on drop#7416
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Oct 17, 2025
Comment on lines
+692
to
+701
| let is_alive_flush_lock = self.is_alive_flush_lock.clone(); | ||
|
|
||
| let flush_op = move || { | ||
| // Keep the guard till the end of the flush to prevent concurrent flushes | ||
| let is_alive_flush_guard = is_alive_flush_lock.lock(); | ||
|
|
||
| if !*is_alive_flush_guard { | ||
| // Segment is removed, skip flush | ||
| return Ok(()); | ||
| } |
Member
There was a problem hiding this comment.
I'd prefer a separate Mutex<()> and stopped flag, I think. It's a mechanism we use already, and then we can more easily propagate the flag throughout the rest of the flusher operation.
But it's not critical. Let's merge this and revisit it if it ever becomes important.
timvisee
pushed a commit
that referenced
this pull request
Nov 14, 2025
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
introduced in #7388