Conversation
generall
commented
Oct 14, 2025
Comment on lines
+949
to
+957
| tokio::task::spawn_blocking(move || { | ||
| Self::flush_worker_internal( | ||
| segments_clone, | ||
| wal_clone, | ||
| wal_keep_from_clone, | ||
| clocks_clone, | ||
| shard_path_clone, | ||
| ) | ||
| }); |
Member
Author
There was a problem hiding this comment.
this is the main change, not time is async, but we spawn thread on wach timeout. (actually, thread keep-alive is higher than that, only one thread is spawned per multiple collections)
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ffuugoo
approved these changes
Oct 14, 2025
6b2c7ba to
711d5f3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Merged
timvisee
approved these changes
Oct 15, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
added a commit
that referenced
this pull request
Nov 14, 2025
* make flush worker loop async * await flush worker properly finishes * simplify flush await * Improved future select, inline return --------- Co-authored-by: timvisee <tim@visee.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One less thread per shard.