Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/common/inference/service.rs (1)

6-6: Fix Retry-After HTTP-date parsing: drop actix_web::HttpDate; use httpdate and clamp past dates to 0 (compile fix).

The current code won’t compile: HttpDate likely doesn’t implement FromStr and SystemTime::from(HttpDate) isn’t available. Also, the .ok().map(...) path drops past dates instead of clamping to zero.

Apply:

- use actix_web::http::header::HttpDate;
+ // Parse HTTP-date without coupling to actix-web
+ use httpdate::parse_http_date;

 fn parse_retry_after(headers: &reqwest::header::HeaderMap) -> Option<Duration> {
     headers
         .get(reqwest::header::RETRY_AFTER)
         .and_then(|value| value.to_str().ok())
         .and_then(|value| {
             // Check if the value is a valid duration in seconds
             if let Ok(seconds) = value.parse::<u64>() {
                 return Some(Duration::from_secs(seconds));
             }
 
-            // Check if the value is a valid Date
-            if let Ok(http_date) = value.parse::<HttpDate>() {
-                let ts = SystemTime::from(http_date);
-                return ts
-                    .duration_since(SystemTime::now())
-                    .ok()
-                    .map(|d| d.max(Duration::ZERO));
-            }
+            // HTTP-date form; clamp past dates to zero
+            if let Ok(ts) = parse_http_date(value) {
+                let delay = match ts.duration_since(SystemTime::now()) {
+                    Ok(d) => d,
+                    Err(_) => Duration::ZERO,
+                };
+                return Some(delay);
+            }
 
             None
         })
 }

Add dependency (if not present):

# Cargo.toml
[dependencies]
httpdate = "1"

Also applies to: 247-268

src/common/inference/service.rs (2)

311-316: Optional: propagate Retry-After on 503/5xx as well.

Servers often include Retry-After with 503 (Service Unavailable). Consider surfacing it to clients (either by adding retry_after to ServiceError or mapping 503+Retry-After to a variant that carries it) so Actix can emit the header.

Would you like me to draft a minimal change to plumb retry_after through ServiceError and set the header in src/actix/helpers.rs for 503?

---

247-268: Add targeted tests for Retry-After parsing (seconds and HTTP-date).

To prevent regressions, add unit tests covering both forms and past HTTP-date (clamped to 0). I can open a test PR if helpful.

Example tests to add in this file’s test module:

#[test]
fn test_parse_retry_after_seconds() {
    let mut headers = reqwest::header::HeaderMap::new();
    headers.insert(reqwest::header::RETRY_AFTER, "7".parse().unwrap());
    let d = InferenceService::parse_retry_after(&headers);
    assert_eq!(d, Some(Duration::from_secs(7)));
}

#[test]
fn test_parse_retry_after_http_date_future() {
    let mut headers = reqwest::header::HeaderMap::new();
    let ts = std::time::SystemTime::now() + Duration::from_secs(3);
    let v = httpdate::fmt_http_date(ts);
    headers.insert(reqwest::header::RETRY_AFTER, v.parse().unwrap());
    let d = InferenceService::parse_retry_after(&headers).unwrap();
    assert!(d.as_secs() <= 3 && d.as_secs() >= 1);
}

#[test]
fn test_parse_retry_after_http_date_past_clamped() {
    let mut headers = reqwest::header::HeaderMap::new();
    let ts = std::time::SystemTime::now() - Duration::from_secs(10);
    let v = httpdate::fmt_http_date(ts);
    headers.insert(reqwest::header::RETRY_AFTER, v.parse().unwrap());
    let d = InferenceService::parse_retry_after(&headers);
    assert_eq!(d, Some(Duration::ZERO));
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro