Log shard transfer abort during consensus recovery#7373
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
generall
approved these changes
Oct 11, 2025
timvisee
reviewed
Oct 13, 2025
Comment on lines
+68
to
+70
| for transfer in shard_transfers.intersection(&old_transfers) { | ||
| log::debug!("Aborting shard transfer: {transfer:?}"); | ||
| } |
Member
There was a problem hiding this comment.
I don't think this is correct.
Transfers that are in both are not necessarily aborted. In fact, it's likely they are not.
They're likely only aborted if the current peer is the source of the transfer, that's what the if-statement below takes care of. Maybe that is the right place to report aborting for intersected transfers.
Wdyt?
timvisee
pushed a commit
that referenced
this pull request
Nov 14, 2025
* Add log line about aborting transfer during consensus recovery
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
devbranch. Did you create your branch fromdev?cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?