remove default explicit config for strict mode#7369
Merged
Conversation
timvisee
approved these changes
Oct 9, 2025
46fa746 to
fca95b7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
added a commit
that referenced
this pull request
Nov 14, 2025
* remove default explicit config for strict mode * Don't prefix commented out properties with space to remain consistent * Don't crash test if strict mode config is not set at all --------- Co-authored-by: timvisee <tim@visee.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit configuration of strict mode makes it harder to properly migrate into cloud, as migration tool replicates full collection configuration from the source to the distanation. But if the distanation is qdrant cloud, we actually want different defaults to be applied.
This PR removes explicit default configuration, which would mean that each deployment would be able to apply env-specific defaults unless user changed it explictily