Skip to content

Type conversions into native Python types for Qdrant on Edge#7367

Merged
generall merged 10 commits intodevfrom
qdrant-edge-python-ext-2
Oct 9, 2025
Merged

Type conversions into native Python types for Qdrant on Edge#7367
generall merged 10 commits intodevfrom
qdrant-edge-python-ext-2

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Oct 8, 2025

Improve Qdrant on Edge Python bindings, by implementing conversion from/into native Python types instead of providing a Python class for each Rust type, which does not feels like Python.

This PR implements conversions for PointId and Payload types. More conversions would be implemented in follow-up PRs.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@generall generall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls move payload.rs -> interfaces/py_paylaod.rs for consistency

@ffuugoo ffuugoo changed the title Implement type conversions for Python bindings for Qdrant on Edge Type conversions into native Python types for Qdrant on Edge Oct 8, 2025
@ffuugoo ffuugoo force-pushed the qdrant-edge-python-ext-2 branch from 9dfd9b6 to adbdb75 Compare October 9, 2025 11:53
@ffuugoo
Copy link
Contributor Author

ffuugoo commented Oct 9, 2025

@generall

  • add conversion for PointId
  • add conversion for Payload
  • rename interface into types
  • remove py_* prefix from file names

@ffuugoo ffuugoo requested a review from generall October 9, 2025 11:58
@ffuugoo ffuugoo marked this pull request as ready for review October 9, 2025 12:29
@coderabbitai

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@generall generall merged commit 8141173 into dev Oct 9, 2025
15 checks passed
@generall generall deleted the qdrant-edge-python-ext-2 branch October 9, 2025 17:19
@ffuugoo ffuugoo added this to the Qdrant on Edge milestone Oct 10, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 1, 2025
9 tasks
timvisee pushed a commit that referenced this pull request Nov 14, 2025
* Cleanup README.md

* Rename `PyResult` into `Result`

* Rename `interface` module into `types` and simplify imports

`wildcard::goes::brrr::*`

* Add `PointId` conversion

* Add `Payload` conversion

* fixup! Add `Payload` conversion

Avoid cloning `Payload` for output conversion

* fixup! Add `PointId` conversion

Fix example

* review fixes #1: fix uuid parsing, avoid .into, use custom types

* review fixes #2: rewrite point id to avoid chain if

* review fixes #3: allow ot use uuid + remove comment

---------

Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants