Type conversions into native Python types for Qdrant on Edge#7367
Merged
Type conversions into native Python types for Qdrant on Edge#7367
Conversation
generall
approved these changes
Oct 8, 2025
Member
generall
left a comment
There was a problem hiding this comment.
LGTM, pls move payload.rs -> interfaces/py_paylaod.rs for consistency
`wildcard::goes::brrr::*`
Avoid cloning `Payload` for output conversion
9dfd9b6 to
adbdb75
Compare
Contributor
Author
|
Fix example
This comment was marked as resolved.
This comment was marked as resolved.
9 tasks
ffuugoo
commented
Oct 9, 2025
ffuugoo
commented
Oct 9, 2025
ffuugoo
commented
Oct 9, 2025
generall
approved these changes
Oct 9, 2025
9 tasks
timvisee
pushed a commit
that referenced
this pull request
Nov 14, 2025
* Cleanup README.md * Rename `PyResult` into `Result` * Rename `interface` module into `types` and simplify imports `wildcard::goes::brrr::*` * Add `PointId` conversion * Add `Payload` conversion * fixup! Add `Payload` conversion Avoid cloning `Payload` for output conversion * fixup! Add `PointId` conversion Fix example * review fixes #1: fix uuid parsing, avoid .into, use custom types * review fixes #2: rewrite point id to avoid chain if * review fixes #3: allow ot use uuid + remove comment --------- Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
9 tasks
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Qdrant on Edge Python bindings, by implementing conversion from/into native Python types instead of providing a Python class for each Rust type, which does not feels like Python.
This PR implements conversions for
PointIdandPayloadtypes. More conversions would be implemented in follow-up PRs.All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: