Merged
Conversation
generall
approved these changes
Oct 7, 2025
ffuugoo
approved these changes
Oct 7, 2025
Merged
3 tasks
timvisee
added a commit
that referenced
this pull request
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
================================================================= FAILURES ================================================================= _______________________________________________________ test_partial_snapshot_empty ________________________________________________________ def test_partial_snapshot_empty(tmp_path: pathlib.Path): # ... # Ensure that both replicas are in sync (because of collection snapshot) and new partial snapshots are empty resp = create_partial_snapshot(write_peer, shard = 0, manifest = get_snapshot_manifest(read_peer)) > assert resp.status_code == 304 E assert 200 == 304 E + where 200 = <Response [200]>.status_code tests/consensus_tests/test_partial_snapshot.py:143: AssertionError ========================================================= short test summary info ========================================================== FAILED tests/consensus_tests/test_partial_snapshot.py::test_partial_snapshot_empty - assert 200 == 304 ============================================================ 1 failed in 11.55s ============================================================Adjust partial snapshot test bootstrapping to wait for a green collection status. This way we are sure there is no asynchronous optimization task messing with our tests.
Before this change,
pytest tests/consensus_tests/test_partial_snapshot.py::test_partial_snapshot_emptyreliably fails for me if I change the number of points to 10k here.All Submissions:
devbranch. Did you create your branch fromdev?