Force flush when taking a snapshot to capture on-going batches#7342
Merged
Force flush when taking a snapshot to capture on-going batches#7342
Conversation
generall
approved these changes
Oct 2, 2025
This was referenced Oct 6, 2025
This was referenced Oct 12, 2025
Merged
timvisee
pushed a commit
that referenced
this pull request
Nov 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7335
The flush needs to be forced to avoid triggering the following optimization
qdrant/lib/segment/src/segment/entry.rs
Lines 629 to 632 in 48203e4
The rational is that operations are split into smaller batches internally and the segment version is bumped with the first batch processed.
Having
version == persisted_versiondoes not ensure that other batches will be captured in storage as well.