Conversation
68d7250 to
c87074c
Compare
0a9bfe4 to
14fed9a
Compare
14fed9a to
7bea254
Compare
e73fd36 to
15ae008
Compare
Fix example + cleanup
timvisee
left a comment
There was a problem hiding this comment.
Looks good!
I passed the test:
$ python3 ./qdrant-edge.py
[0.5126146078109741, 0.7689219117164612, 0.3417430818080902, 0.1708715409040451]
There was a problem hiding this comment.
My only nit here is that this interface seems very different than what we currently offer in your Python client.
I'm curious if that is desired. Ideally we use something similar so that we can reuse parts of our documentation, and don't confuse users.
Thoughts?
| match storage_type { | ||
| PayloadStorageType::Mmap => (), | ||
| PayloadStorageType::InRamMmap => (), | ||
| _ => todo!(), // TODO: Ignore RocksDB storage types |
There was a problem hiding this comment.
We can feature flag it and implement the bare minimum (probably still with unimplemented!()).
Then we'll fully remove it once dropping the RocksDB feature, and don't keep the _ => branch here.
|
|
||
| #[pyclass(name = "SearchRequest")] | ||
| #[derive(Clone, Debug, Into)] | ||
| pub struct PySearchRequest(CoreSearchRequest); |
There was a problem hiding this comment.
CoreSearchRequest is soon-to-be deprecated structure, in the core it is only used for old search method, which we want to continue gradually removing in 1.16.x
I would avoid making any more dependants on it
This comment was marked as resolved.
This comment was marked as resolved.
* Qdrant Edge Python binding 🐍⛓️💥 * fixup! Qdrant Edge Python binding 🐍⛓️💥 Fix example + cleanup * review: move QueryEnum + mark search as deprecated --------- Co-authored-by: generall <andrey@vasnetsov.com>
This PR Implements partial Python bindings for Qdrant Edge. So far only basic upsertion and search are implemented, but bindings are boilerplate-heavy, so more types and methods would be covered in follow-up PRs.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: