lib/collection/src/shards/local_shard/telemetry.rs (1)

183-204: Defer “should this segment be included in indexed_only?” to segment API (once available).

Per earlier discussion, prefer a single per‑segment decision method to centralize logic (index presence + threshold checks). Since this was implemented in PR #7463, consider using it here when merged to avoid drift.

Example (pseudocode):

if !segment_guard.include_in_indexed_only(&vector_name, search_optimized_threshold_bytes) {
    // accumulate excluded
}

src/actix/api/service_api.rs (1)

81-84: Confirm Level4 is required for metrics population

Raising TelemetryDetail.level to Level4 makes sense if indexed_only_excluded_vectors is only populated at Level4. Please confirm there’s no cheaper level that still provides this field, and consider noting this rationale in a short comment to avoid future regressions.

lib/collection/src/shards/telemetry.rs (1)

68-70: Telemetry privacy: do we anonymize map keys (vector names)?

indexed_only_excluded_vectors is HashMap<String, usize>. When anonymize() is requested, do HashMap keys get anonymized? If not, vector names may leak. Consider adding an anonymization strategy for keys or documenting that names are intended to be public.

Additionally, consider u64 for counts to avoid platform-dependent usize serialization differences.

docs/redoc/master/openapi.json (2)

12217-12225: Please document semantics and provide an example for indexed_only_excluded_vectors.

Add a short description clarifying:

• It maps vector names to the number of points excluded when indexed_only=true.
• The empty string key represents the default unnamed vector (if applicable).

Optional example improves discoverability.

Apply this minimal patch:

           "indexed_only_excluded_vectors": {
+            "description": "Per-vector counts of points excluded from search when `indexed_only` is enabled. Key is the vector name; use empty string \"\" for the default unnamed vector.",
             "type": "object",
             "additionalProperties": {
               "type": "integer",
               "format": "uint",
               "minimum": 0
             },
-            "nullable": true
+            "nullable": true,
+            "example": { "": 89500, "image-embeddings": 1200 }
           }

---

12217-12225: Rename struct field to align with metric and semantic meaning.

The struct field indexed_only_excluded_vectors represents point counts (confirmed by metric collection_indexed_only_excluded_points and its description). Rename the field to indexed_only_excluded_points in:

• lib/collection/src/shards/telemetry.rs (line 69)
• Update all usages in lib/collection/src/shards/local_shard/telemetry.rs and lib/collection/src/shards/dummy_shard.rs
• Update docs/redoc/master/openapi.json to reflect the field name change

This aligns the struct field naming with the Prometheus metric collection_indexed_only_excluded_points and eliminates confusion about what the values represent.

lib/collection/src/shards/local_shard/telemetry.rs (2)

21-43: Good use of spawn_blocking; avoid name shadowing for clarity.

Logic is sound. Minor readability: don’t reuse segments for telemetry results (it shadows the earlier self.segments). Rename to segments_telemetry.

Apply:

-        let (segments, index_only_excluded_vectors) = segments_data.unwrap_or_default();
+        let (segments_telemetry, index_only_excluded_vectors) = segments_data.unwrap_or_default();
@@
-            segments: if segments.is_empty() {
+            segments: if segments_telemetry.is_empty() {
                 None
             } else {
-                Some(segments)
+                Some(segments_telemetry)
             },

Also applies to: 48-49, 80-84

---

171-198: Avoid unwrap; simplify error handling when fetching vector storage size.

Refactor to a match to remove unwrap() after the error branch and reduce footguns.

-                    let vector_storage_size =
-                        segment_guard.available_vectors_size_in_bytes(&vector_name);
-
-                    if let Err(err) = vector_storage_size {
-                        log::error!("Failed to get vector size from segment: {err:?}");
-                        return None;
-                    }
-
-                    let points = segment_guard.available_point_count();
-                    Some((vector_name, vector_storage_size.unwrap(), points))
+                    match segment_guard.available_vectors_size_in_bytes(&vector_name) {
+                        Ok(size_bytes) => {
+                            let points = segment_guard.available_point_count();
+                            Some((vector_name, size_bytes, points))
+                        }
+                        Err(err) => {
+                            log::error!("Failed to get vector size from segment: {err:?}");
+                            None
+                        }
+                    }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro