Conversation
691a75f to
facfe31
Compare
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughChanges in lib/shard/src/segment_holder/mod.rs adjust deletion and proxy-apply behavior. In apply_points, deletion of points now occurs only if a concrete version (Some(version)) is returned; deletions are skipped when no version exists. In proxy_all_segments_and_apply, the reversal of the proxies vector before iteration was removed, changing the order in which proxies are processed during the apply/unproxy phase. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removing the reverse proxy traversal introduced in https://github.com/qdrant/qdrant/pull/7248/files#r2344371758 happened to trigger one of the new assertion from #7300
Tracking the version I found that it was synthetic to replace the absent value.