Refactor scroll by arguments#7296
Merged
generall merged 2 commits intoslow-requests-log-2from Sep 24, 2025
Merged
Conversation
timvisee
approved these changes
Sep 24, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
I have to admit that I found it a bit hard to see how the code paths have changed, simply because all these methods have roughly the same name. But I don't see any problems when manually going over each path in the new branch, and am confident it works.
I did not find any limit+1 issues.
generall
added a commit
that referenced
this pull request
Oct 27, 2025
* separate internal scroll operation from the one used by user * fmt
generall
added a commit
that referenced
this pull request
Oct 27, 2025
…ieve (#7291) * reorder arguments of scroll_by * add slow request log for scroll request * add slow request log for facet request * add slow request log for count request * add slow request log for retrieve request * Remove obsolete clone * generic implementation of Loggable for Arc * Refactor scroll by arguments (#7296) * separate internal scroll operation from the one used by user * fmt --------- Co-authored-by: Tim Visée <tim+github@visee.me>
timvisee
added a commit
that referenced
this pull request
Nov 14, 2025
…ieve (#7291) * reorder arguments of scroll_by * add slow request log for scroll request * add slow request log for facet request * add slow request log for count request * add slow request log for retrieve request * Remove obsolete clone * generic implementation of Loggable for Arc * Refactor scroll by arguments (#7296) * separate internal scroll operation from the one used by user * fmt --------- Co-authored-by: Tim Visée <tim+github@visee.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
separate internal scroll operation from the one used by user
Previously, we had a single
scroll_byfunction on a shard level, which were used by both: user requests and internal scrolls.This PR creates one additional entry point for internal scroll requests, and switches all internal functions to it. In this way we can guarantee that: