tests/consensus_tests/test_shard_snapshot_deadlock.py (1)

27-30: Make loop_collection_info resilient and stoppable

As written, any transient RequestException will terminate the loop and reduce the intended pressure. Also consider an optional stop flag to allow graceful shutdown in finally.

Apply:

-def loop_collection_info(peer_url):
-    while True:
-        requests.get(f"{peer_url}/collections/test_collection", timeout = 0.5)
+def loop_collection_info(peer_url, stop=None, session=None):
+    sess = session or requests.Session()
+    try:
+        while stop is None or not stop.is_set():
+            try:
+                sess.get(f"{peer_url}/collections/test_collection", timeout=0.5)
+            except requests.RequestException:
+                # ignore and continue to keep pressure on the endpoint
+                pass
+    finally:
+        if session is None:
+            sess.close()

Optionally mirror this pattern in the other loop_* helpers and pass a shared threading.Event you set in the finally block before executor shutdown. Happy to provide a full diff across the file if you want that change.

lib/collection/src/shards/local_shard/mod.rs (2)

1103-1129: Good: moves per‑segment aggregation off Actix via spawn_blocking

This removes blocking work from the RT thread while keeping segment access under a blocking read. LGTM. One minor improvement: consider taking a snapshot of segment handles (if feasible) under the short read lock and then iterating them after dropping the holder read lock to minimize contention.

---

1130-1136: Streamline error handling and keep context

Current pattern logs Err then unwrap_or_default(). A compact match avoids double handling and lets you add context once.

Apply:

-        let segment_info = tokio::task::spawn_blocking(move || {
+        let segment_info = tokio::task::spawn_blocking(move || {
             // ... unchanged ...
-        })
-        .await;
-
-        if let Err(err) = &segment_info {
-            log::error!("Failed to get local shard info: {err}");
-        }
-
-        let (schema, indexed_vectors_count, points_count, segments_count) =
-            segment_info.unwrap_or_default();
+        }).await;
+
+        let (schema, indexed_vectors_count, points_count, segments_count) = match segment_info {
+            Ok(res) => res,
+            Err(err) => {
+                log::error!("Failed to get local shard info: {err}");
+                Default::default()
+            }
+        };

Also, please confirm that merging PayloadIndexInfo by summing only points (keeping other fields from the first seen segment) matches intended semantics across segments.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro