Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Sep 16, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
Great find! Yes, here we try to sync before all data from the writer is flushed.
I changed to logic a bit. The write buffer now wraps the owned type. It makes it impossible to call sync_all without explicitly flushing it first.
I applied the same to all other write buffer instances, as there were some inconsistencies.
timvisee
reviewed
Sep 16, 2025
Comment on lines
337
to
345
| // Write mappings to disk. | ||
| let file = File::create(Self::mappings_file_path(path))?; | ||
| let mut writer = BufWriter::new(&file); | ||
| let mut writer = BufWriter::new(file); | ||
| Self::store_mapping(&mappings, &mut writer)?; | ||
|
|
||
| // Explicitly fsync file contents to ensure durability | ||
| writer.flush()?; | ||
| let file = writer.into_inner().unwrap(); | ||
| file.sync_all()?; |
Member
There was a problem hiding this comment.
Key change is here: first flush, then sync_all.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
added a commit
that referenced
this pull request
Sep 29, 2025
* add missed flush buffer * For all BufWriters, wrap owned type and explicitly flush --------- Co-authored-by: timvisee <tim@visee.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also checked other places with sync_all, seems to be the only one missing.