make sure that grpc::Vector can always use new format#7185
Merged
Conversation
This was referenced Aug 29, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
coszio
approved these changes
Sep 1, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
generall
commented
Sep 1, 2025
lib/api/src/conversions/vectors.rs
Outdated
| fn from(vector: VectorInternal) -> Self { | ||
| // ToDo: before deprecating `data`, `indices`, and `vectors_count`, ensure | ||
| // ToDo: that `vector` field is generated here. | ||
| // ToDo(v1.18): before deprecating `data`, `indices`, and `vectors_count`, ensure |
Member
Author
There was a problem hiding this comment.
this specific part can be updated earlier, as it is only for internal cluster operations
generall
commented
Sep 1, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Sep 5, 2025
timvisee
pushed a commit
that referenced
this pull request
Sep 29, 2025
* make sure that grpc::Vector can always use new format * specify target version for ToDo * Update lib/api/src/conversions/vectors.rs --------- Co-authored-by: Luis Cossío <luis.cossio@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some internal APIs were still relying on the old format of
grpc::Vector.This PR covers last missing parts of missing conversions, so that in the next version we can deprecate old format and always generate structures using a new one