Skip to content

do not anonymize peer id#7177

Merged
generall merged 1 commit intodevfrom
do-not-anonymize-peer-id
Aug 29, 2025
Merged

do not anonymize peer id#7177
generall merged 1 commit intodevfrom
do-not-anonymize-peer-id

Conversation

@generall
Copy link
Member

No description provided.

coderabbitai[bot]

This comment was marked as resolved.

Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for this one?

Specific peer IDs would allow us to link it to a specific cluster more easily.

@generall
Copy link
Member Author

Any specific reason for this one?

  1. Peer ids are already exposed in other structures, so we are not hiding anything additional here
  2. Peer ids are random, exposing them doesn't let us de-anon anything
  3. With this PR change we will be able to restore shards-to-peers distribution, which is needed for checking if cluster is evenly balanced

@generall generall merged commit 2c6cc22 into dev Aug 29, 2025
16 checks passed
@generall generall deleted the do-not-anonymize-peer-id branch August 29, 2025 18:09
timvisee pushed a commit that referenced this pull request Sep 29, 2025
@timvisee timvisee mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants