Use locked segment by reference without cloning Arc#7176
Merged
Conversation
timvisee
commented
Aug 29, 2025
| let segment = match proxy_segment { | ||
| LockedSegment::Proxy(proxy_segment) => { | ||
| proxy_segment.read().wrapped_segment.clone().get() | ||
| proxy_segment.read().wrapped_segment.get_cloned() |
Member
Author
There was a problem hiding this comment.
Effectively the only place (outside tests) where we actually need the owned Arc by cloning it.
agourlay
approved these changes
Aug 29, 2025
JojiiOfficial
approved these changes
Aug 29, 2025
xzfc
approved these changes
Aug 29, 2025
timvisee
added a commit
that referenced
this pull request
Sep 29, 2025
* Use locked segment by reference without cloning Arc * Remove unnecessary clone * Return list of lock references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer to use a locked segment by reference, without cloning an Arc.
We use this function in at least 189 different places (including tests). This way we prevent unnecessarily bumping an atomic counter twice with each interaction.
I don't expect to see a noticeable difference in end to end benchmarks, but doing less work at runtime is always good. This function may be considered hot, and we've seen performance problems on very large CPUs when bumping a lot of atomics.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?