Skip to content

Flush worker fixes#7151

Merged
timvisee merged 1 commit intodevfrom
flush-worker-fixes
Aug 27, 2025
Merged

Flush worker fixes#7151
timvisee merged 1 commit intodevfrom
flush-worker-fixes

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Aug 26, 2025

Small fixes to UpdateHandler::flush_worker based on this coderabbitai comment in #7146.

  • rename wal_flash_job to wal_flush_job
  • correctly handle/report WAL flush errors

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo changed the base branch from master to dev August 26, 2025 15:40
@ffuugoo ffuugoo marked this pull request as ready for review August 26, 2025 15:41
@ffuugoo ffuugoo requested review from generall and timvisee August 26, 2025 15:42
@coderabbitai

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as off-topic.

- rename `wal_flash_job` to `wal_flush_job`
- correctly handle/report WAL flush errors
@ffuugoo ffuugoo force-pushed the flush-worker-fixes branch from fff31f0 to f8259fa Compare August 27, 2025 11:51
coderabbitai[bot]

This comment was marked as resolved.

@timvisee timvisee merged commit d17f54c into dev Aug 27, 2025
16 checks passed
@timvisee timvisee deleted the flush-worker-fixes branch August 27, 2025 12:16
timvisee pushed a commit that referenced this pull request Sep 29, 2025
- rename `wal_flash_job` to `wal_flush_job`
- correctly handle/report WAL flush errors
@timvisee timvisee mentioned this pull request Sep 29, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants