Mirgate from old shard key format on load#7110
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Aug 21, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
Great! Extensively tested it and it behaves like I expect. Thanks.
I've added one debug line at the moment we migrate.
9 tasks
timvisee
added a commit
that referenced
this pull request
Aug 26, 2025
* Migrate shard-key format * Reduce visibility of was_old_format attribute * Add debug message when we migrate persisted shard key format --------- Co-authored-by: timvisee <tim@visee.me>
Merged
6 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for #7047
Migrates to the new shard key format (#5838 and #6209) when loading a collection.
Todo