Skip to content

Move SegmentHolder::scroll_read_lock to LocalShard#7053

Merged
ffuugoo merged 1 commit intodevfrom
local-shard-scroll-lock
Aug 18, 2025
Merged

Move SegmentHolder::scroll_read_lock to LocalShard#7053
ffuugoo merged 1 commit intodevfrom
local-shard-scroll-lock

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Aug 13, 2025

This removes tokio dependency from SegementHolder, so it's easier to extract SegmentHolder into separate crate for Qdrant Edge. 😔

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

This removes `tokio` dependency from `SegementHolder`, so it's easier
to extract `SegmentHolder` into separate crate for Qdrant Edge 😔
@ffuugoo ffuugoo changed the title Move SegmentHolder::scroll_read_lock to LocalShard::scroll_read_lock Move SegmentHolder::scroll_read_lock to LocalShard Aug 13, 2025
@ffuugoo ffuugoo requested review from generall and timvisee August 13, 2025 15:23
@ffuugoo ffuugoo marked this pull request as ready for review August 13, 2025 15:23
@coderabbitai

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants