Refactor Collection::restore_shard_snapshot#6988
Merged
Conversation
Propagate `TempFile` into `Collection::restore_shard_snapshot`
This comment was marked as off-topic.
This comment was marked as off-topic.
generall
reviewed
Aug 6, 2025
generall
approved these changes
Aug 6, 2025
timvisee
approved these changes
Aug 6, 2025
timvisee
pushed a commit
that referenced
this pull request
Aug 11, 2025
This was referenced Nov 28, 2025
Merged
This was referenced Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two improvements to
Collection::restore_shard_snapshot:First, it makes it cancel-safe, so that it's a bit safer to use. I don't think we have any issues with this method as-is, but it's just nice to have.
Second, restructures
restore_shard_snapshotas a "two-step" future. It now returns additional future. E.g.:All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: