Fix config path & Webui Assets in Debian package by JojiiOfficial · Pull Request #6958 · qdrant/qdrant

JojiiOfficial · 2025-07-30T12:51:10Z

Supersedes #6716
Fixes #4573
Fixes #3370

Fixes including WebUI assets in Debian packages
Sets default config path on debian to /etc/qdrant/config.yaml, set through a compile-time env-var
Changes assets, storage and snapshots path to /var/lib/qdrant/static

coderabbitai · 2025-07-30T12:55:49Z

📝 Walkthrough

Walkthrough

This change updates the Debian packaging and configuration for Qdrant. In Cargo.toml, the static asset file mappings are modified to copy files from static/* and static/assets/* into /var/lib/qdrant/static/ and /var/lib/qdrant/static/assets/ instead of /etc/qdrant/static. The config/deb.yaml file is updated to set the static content directory to /var/lib/qdrant/static and introduces a new storage section specifying absolute paths for storage and snapshots under /var/lib/qdrant. The only Rust code change is a minor refactor in src/settings.rs for pattern matching style, with no functional impact.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Ensure static files (dashboard and assets) are included in the Debian package (#4573)	✅
Static files and web UI assets should be installed to /var/lib/qdrant/static (#3370, #4573)	✅
Use absolute paths for storage, snapshots, and static content in config/deb.yaml (#3370)	✅
No functional or exported/public code changes outside packaging and config (#4573, #3370)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes detected. All modifications are directly related to Debian package file mappings, configuration paths, or minor internal code refactoring without functional impact.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4878bfc and 077d962.

📒 Files selected for processing (1)

src/settings.rs (1 hunks)

✅ Files skipped from review due to trivial changes (1)

src/settings.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

GitHub Check: e2e-tests
GitHub Check: test-shard-snapshot-api-s3-minio
GitHub Check: test-consistency
GitHub Check: test-consensus-compose
GitHub Check: integration-tests
GitHub Check: storage-compat-test
GitHub Check: integration-tests-consensus
GitHub Check: lint
GitHub Check: rust-tests (macos-latest)
GitHub Check: rust-tests (ubuntu-latest)
GitHub Check: rust-tests (windows-latest)
GitHub Check: rust-tests-no-rocksdb (ubuntu-latest)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix_debian_config_path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

timvisee · 2025-07-30T14:29:37Z

src/settings.rs

        // Merge user provided config with --config-path
        if let Some(path) = custom_config_path {
-            config = config.add_source(File::with_name(&path).required(false));
+            config = config.add_source(File::with_name(path).required(false));


I only now notice this 🤦‍♂️ :

qdrant/src/settings.rs

Lines 267 to 271 in 8b5b244

#[cfg(feature = "deb")]

{

// Read config, installed with deb package

config = config.add_source(File::with_name("/etc/qdrant/config").required(false));

}

Which means we were already loading the installed configuration file. I was under the assumption it was never loaded unless specified.

I think it makes your changes with CUSTOM_CONFIG_PATH_OVERWRITE obsolete, and we can undo them.

The other path changes can remain.

* Fix debian config location & WebUI assets * remove config overwrite env variable again

Fix debian config location & WebUI assets

4878bfc

timvisee requested changes Jul 30, 2025

View reviewed changes

remove config overwrite env variable again

077d962

JojiiOfficial requested a review from timvisee July 31, 2025 07:22

timvisee approved these changes Jul 31, 2025

View reviewed changes

JojiiOfficial merged commit 4b6806b into dev Jul 31, 2025
16 checks passed

JojiiOfficial deleted the fix_debian_config_path branch July 31, 2025 08:02

This was referenced Jul 31, 2025

Use absolute qdrant directory in debian package #6716

Closed

Files missing from Debian package. #4573

Closed

Debian package should use absolute Qdrant directory #3370

Closed

timvisee pushed a commit that referenced this pull request Aug 11, 2025

Fix config path & Webui Assets in Debian package (#6958)

9ab1fca

* Fix debian config location & WebUI assets * remove config overwrite env variable again

timvisee mentioned this pull request Aug 11, 2025

Bump version to 1.15.2 #7012

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix config path & Webui Assets in Debian package#6958

Fix config path & Webui Assets in Debian package#6958
JojiiOfficial merged 2 commits intodevfrom
fix_debian_config_path

JojiiOfficial commented Jul 30, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 30, 2025 •

edited

Loading

Walkthrough

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

timvisee Jul 30, 2025 •

edited

Loading

Uh oh!

JojiiOfficial Jul 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	#[cfg(feature = "deb")]
	{
	// Read config, installed with deb package
	config = config.add_source(File::with_name("/etc/qdrant/config").required(false));
	}

Conversation

JojiiOfficial commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

timvisee Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JojiiOfficial Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JojiiOfficial commented Jul 30, 2025 •

edited

Loading

coderabbitai bot commented Jul 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

timvisee Jul 30, 2025 •

edited

Loading