Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
timvisee
approved these changes
Jun 26, 2025
Comment on lines
+513
to
+519
| DistanceType::Dot => { | ||
| self.metadata.actual_dim as f32 * self.metadata.offset * self.metadata.offset | ||
| } | ||
| DistanceType::L1 => 0.0, | ||
| DistanceType::L2 => { | ||
| self.metadata.actual_dim as f32 * self.metadata.offset * self.metadata.offset | ||
| } |
Member
There was a problem hiding this comment.
These are the same. We can merge them if we like:
Suggested change
| DistanceType::Dot => { | |
| self.metadata.actual_dim as f32 * self.metadata.offset * self.metadata.offset | |
| } | |
| DistanceType::L1 => 0.0, | |
| DistanceType::L2 => { | |
| self.metadata.actual_dim as f32 * self.metadata.offset * self.metadata.offset | |
| } | |
| DistanceType::Dot | DistanceType::L2 => { | |
| self.metadata.actual_dim as f32 * self.metadata.offset * self.metadata.offset | |
| } | |
| DistanceType::L1 => 0.0, |
generall
approved these changes
Jun 26, 2025
generall
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Fix SQ internal vector encoding * add test * clippy warning
Merged
This was referenced Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes SQ accuracy lost after #6729.
The problem was with the calculation of the vector's
offsetvalue (what is theoffsetvalue for an SQ vector? You can find it here: https://qdrant.tech/articles/scalar-quantization/).This value is different between vector and query. For query (in Dot metric) it's
For the vector it's
This PR fixes difference in query internal method. Test included.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: