Skip to content

Unify strict mode checks between REST and gRPC APIs#6616

Merged
ffuugoo merged 6 commits intodevfrom
update-api-common-strict-mode
Jun 5, 2025
Merged

Unify strict mode checks between REST and gRPC APIs#6616
ffuugoo merged 6 commits intodevfrom
update-api-common-strict-mode

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented May 30, 2025

Moves strict mode checks into common::update module. Removes ~50 LoC of duplicating check_strict_mode in REST and gRPC. Uses existing CheckedTocProvider trait (it was only used for gRPC before, but not used for both gRPC and REST). Behavior is exactly the same.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo marked this pull request as ready for review May 30, 2025 16:44
@coderabbitai

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as off-topic.

@ffuugoo ffuugoo merged commit 0f61cbd into dev Jun 5, 2025
17 checks passed
@ffuugoo ffuugoo deleted the update-api-common-strict-mode branch June 5, 2025 17:51
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2025
9 tasks
@coderabbitai coderabbitai bot mentioned this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants