Fix consensus snapshot not applying shard key mappings#6212
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
9 tasks
generall
approved these changes
Mar 20, 2025
timvisee
added a commit
that referenced
this pull request
Mar 21, 2025
* Propagate shard key mapping wrapper deeper * Also bump reverse shard mapping when applying shard keys from snapshot * Also apply new shard key mappings to existing replicas * Apply shard key to replica set through apply_state directly * Set both new shard key mappings through utility function * Set shard key mappings directly during directory creation * Rename get_key to key * Update comment
Merged
9 tasks
This was referenced Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #6210.
Shard key mappings were not applied properly in some places when using a consensus snapshot. This fixes the issue.
Some key places that were forgotten:
A proper test for this is implemented in #6213.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?