[score boosting] fix proxy segment leakage#6170
Conversation
| .rescore_with_formula(formula_ctx, hw_counter)?; | ||
|
|
||
| // Just join both results, they will be deduplicated and top-k'd later | ||
| write_results.append(&mut wrapped_results); |
There was a problem hiding this comment.
Here we also fix the fact that we were returning the wrong Vec. We were returning the empty one 💀
📝 WalkthroughWalkthroughThis pull request removes the Possibly related PRs
Suggested reviewers
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (13)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| } else { | ||
| // Create a hashmap of write results by point ID for faster lookup | ||
| // We expect write results to be shorter than wrapped results | ||
| let mut write_results_map: AHashMap<_, _> = write_results |
There was a problem hiding this comment.
I would prefer to avoid allocating HashMaps when possible. This is potentially an expensive operation.
There was a problem hiding this comment.
Duh, this is much better, thanks
* remove deleted bitslice from rescore_with_formula signature * dont allocate unnecessary ahash --------- Co-authored-by: generall <andrey@vasnetsov.com>
The signature for
rescore_with_formulaincluded a deleted bitslice only because the proxy segment would introduce it to handle the write and wrapped results.In this PR, we remove the abstraction leak, and handle the logic to prefer write results only within the proxy segment.