Mutable ID tracker: implement storage for point versions#6169
Merged
Conversation
18 tasks
12 tasks
ffuugoo
approved these changes
Mar 17, 2025
eae265e to
05172b4
Compare
12 tasks
05172b4 to
1c38a5d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
coszio
approved these changes
Mar 17, 2025
timvisee
commented
Mar 18, 2025
6eab330 to
836eb76
Compare
This was referenced Mar 19, 2025
timvisee
added a commit
that referenced
this pull request
Mar 21, 2025
* Persist version changes as internal to version mapping, not external * Read and write versions into file directly * Warn if versions file has unexpected size * Optimize writing batch of versions, only seek if needed * Don't explicitly resize file, it'll be done automatically * Minor refactoring * review nits --------- Co-authored-by: Luis Cossío <luis.cossio@outlook.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked in: #6157
Depends on: #6166
Implement the new storage for point versions.
This changes the mapping of versions from external ID to version to internal ID to version.
Points are kept in memory for fast access. On load we read the full list of versions. On flush we store we write all changed versions directly to the versions file.
Writing changes is optimized to properly buffer all writes. This has a great effect if writing a big batch of versions, to use a lot less intermediate syscalls.
In terms of the file format, the file on disk is just a contiguous list of version numbers similar to an array.
Tasks
devAll Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?