Merged
Conversation
JojiiOfficial
approved these changes
Mar 5, 2025
Contributor
JojiiOfficial
left a comment
There was a problem hiding this comment.
This is a nice addition. Thanks!
timvisee
approved these changes
Mar 5, 2025
| /// including the final one where it usually returns `None`. | ||
| /// | ||
| /// Consider subtracting 1 if the final `None` is not needed. | ||
| fn on_final_count<F>(self, f: F) -> OnFinalCount<Self, F> |
Member
There was a problem hiding this comment.
A bit verbose, but how about count_callback_on_drop? It might give a better hint on what it does without looking at the function.
I've no strong opinion on either.
Contributor
There was a problem hiding this comment.
I'm fine with both but agree this one being more self-explanatory
timvisee
pushed a commit
that referenced
this pull request
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an iterator adapter to make hardware usage counting easier when we are measuring iterators.
This adapter plugs in easily to an iterator. When the iterator gets dropped, it will execute the callback to do something with the final number of iterations the iterator was used for.
For example:
I am not sure about the name, though. Feel free to propose another one :)