Skip to content

Add common::update::update function#5977

Merged
ffuugoo merged 1 commit intodevfrom
update-api-common-update
Feb 18, 2025
Merged

Add common::update::update function#5977
ffuugoo merged 1 commit intodevfrom
update-api-common-update

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Feb 12, 2025

The last small refactoring for the update API layer. Adds a common update function that is a bit easier to call than toc.update(<lots-of-garbage>) and tweaks all do_update_operation functions to use it. This way we only need to destructure UpdateParams and InternalUpdateParams once.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this has no logic changes 👍

@ffuugoo ffuugoo merged commit d5884d0 into dev Feb 18, 2025
17 checks passed
@ffuugoo ffuugoo deleted the update-api-common-update branch February 18, 2025 10:49
timvisee pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants