Merged
Conversation
0ae071e to
ddd2984
Compare
timvisee
approved these changes
Nov 27, 2024
Member
timvisee
left a comment
There was a problem hiding this comment.
Looks good, though it's a bit hard to track where things have moved exactly.
Thanks for replacing those transmutes.
generall
approved these changes
Nov 27, 2024
coszio
pushed a commit
that referenced
this pull request
Dec 2, 2024
timvisee
pushed a commit
that referenced
this pull request
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
GraphLinksConverterin preparation for adding support for compressing.GraphLinksFileHeaderis split intoGraphLinksFileHeader(on-disk representation) andGraphLinksFileInfo(in-memory, all offsets are calculated).mmap_ops::transmute_from_u8_to_slicewith equivalents from thetransmutecrate (as I find it to be more sound).impl Writesequentially rather than into&mut [u8].