GraphLinksConverter: take m and compressed arguments#5489
Merged
Conversation
35fb5e6 to
7935763
Compare
7935763 to
dadcf8e
Compare
timvisee
approved these changes
Nov 27, 2024
dadcf8e to
ee66661
Compare
ee66661 to
bfd5f2a
Compare
IvanPleshkov
requested changes
Dec 9, 2024
Contributor
IvanPleshkov
left a comment
There was a problem hiding this comment.
Requested change to refactor hardcoded m0 = m * 2 logic. I find important to move it as a separate function
8c809c7 to
17ddc3f
Compare
generall
approved these changes
Dec 9, 2024
IvanPleshkov
approved these changes
Dec 10, 2024
timvisee
pushed a commit
that referenced
this pull request
Jan 8, 2025
* GraphLinksConverter: take `m` and `compressed` arguments * Add m0 parameter * Fixup * LinkCompressionExperimentalSetting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs some integration work required for HNSW links compression.
GraphLinksConverter::new()now takesm: usizeandcompression: bool. It is assumed that compression algorithm might sort the firstm/2*mlinks for each node.__QDRANT_COMPRESSED_LINKS. When set, it will enable creation of compressed graphs for testing/debugging purposes. By default it's disabled.Assumption:
m0 == 2*m.Depends on #5486, ignore the first commit during review.