Non blocking retrieve with timeout and cancellation support#4844
Merged
Non blocking retrieve with timeout and cancellation support#4844
Conversation
agourlay
commented
Aug 7, 2024
| let records_map = | ||
| SegmentsSearcher::retrieve(self.segments(), &request.ids, with_payload, with_vector)?; | ||
| let timeout = timeout.unwrap_or(self.shared_storage_config.search_timeout); | ||
| let records_map = tokio::time::timeout( |
Member
Author
There was a problem hiding this comment.
where the rubber meets the road
1da05ec to
3601a4c
Compare
timvisee
approved these changes
Aug 8, 2024
Comment on lines
+353
to
+354
| runtime_handle | ||
| .spawn_blocking({ |
Member
There was a problem hiding this comment.
For reviewers, important part: here we now spawn blocking tasks for each segment segment holder.
Member
Author
There was a problem hiding this comment.
Having one task per segment is possible optimization (marked by a TODO below)
For now there is one task per segment_holder, so just one per request/shard :)
generall
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Non blocking retrieve with timeout and cancellation support * apply timeout for extra retrieve in rescoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performing a retrieve operation at the segment level is a blocking operation:
This PR makes retrieving asynchronous & multithreaded so it does not block anymore Tokio threads which can cause various responsiveness issues.
It also applies additional measures to: