Conversation
efdca9a to
780ed2d
Compare
timvisee
approved these changes
May 21, 2024
9 tasks
e35c780 to
a0f6c4d
Compare
9 tasks
* fs4@0.8.4 * fail early on low storage * move `dir_size` to `common` * move the ood bailout to `SegmentOptimizer::optimized_segment_builder` * drop dead code * move dir_size to common subcrate --------- Co-authored-by: generall <andrey@vasnetsov.com>
generall
added a commit
that referenced
this pull request
Jun 29, 2024
* Add test for OOD during indexing * Start indexing right after 1st OOD message * Only send search request after insert loop * Fail early when encountering out-of-storage during optimization (#4578) * fs4@0.8.4 * fail early on low storage * move `dir_size` to `common` * move the ood bailout to `SegmentOptimizer::optimized_segment_builder` * drop dead code * move dir_size to common subcrate --------- Co-authored-by: generall <andrey@vasnetsov.com> --------- Co-authored-by: xhjkl <xhjkl@users.noreply.github.com> Co-authored-by: generall <andrey@vasnetsov.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automate a test scenario for OutOfDisk error during indexing.
Scenario:
Limit Qdrant container disk to ~10 MB
Expected behavior: indexing should gracefully fail without crushing a container and post a log message, the container should continue running and accept search requests.
All Submissions:
devbranch. Did you create your branch fromdev?