Skip to content

refactor: Added method overloads with request objects#22

Merged
Anush008 merged 1 commit into
masterfrom
request-object-methods
Feb 28, 2024
Merged

refactor: Added method overloads with request objects#22
Anush008 merged 1 commit into
masterfrom
request-object-methods

Conversation

@Anush008

@Anush008 Anush008 commented Feb 22, 2024

Copy link
Copy Markdown
Member

Description

This PR adds method overloads using the request objects directly. To be used if the other overloads are missing a supported option. For example #20.

Also, marks some overloads as public with docstrings.

@Anush008 Anush008 requested a review from russcam February 22, 2024 06:29
@Anush008 Anush008 force-pushed the request-object-methods branch from b7fcd2b to f7c1297 Compare February 22, 2024 06:36
@Anush008 Anush008 linked an issue Feb 22, 2024 that may be closed by this pull request
@Anush008 Anush008 merged commit 06b6c8d into master Feb 28, 2024
@Anush008 Anush008 deleted the request-object-methods branch February 28, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot set shardKey when deleting vectors

2 participants