fix: fix pad to square for some rectangular images#421
Merged
Conversation
hh-space-invader
added a commit
that referenced
this pull request
Dec 16, 2024
* WIP: Added jina clip text embedding * WIP: Added preprocess for jina clip * WIP: Added jina clip vision (not sure if it works yet) * improve: Improved mean pooling if the output doesnt have seq length * fix: Fixed jina clip text * nit * fix: Fixed jina clip image preprocessor * fix: Fix type hints new: added resize2square * tests: Add jina clip vision test case * nit * refactor: Update fastembed/image/transform/operators.py Co-authored-by: George <george.panchuk@qdrant.tech> * fix: Fix indentation * refactor: Refactored how we call padding for image * fix: Fix pad to image when resized size larger than new square canvas * refactor: minor refactor * refactor: Refactor some functions in preprocess image * fix: Fix to pad image with specified fill color * refactor: Change resize to classmethod * fix: Fix jina clip text v1 * fix: fix pad to square for some rectangular images (#421) --------- Co-authored-by: George <george.panchuk@qdrant.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.