iOS support: handle QProcess being not available#153
Merged
danvratil merged 1 commit intoqcoro:mainfrom Feb 23, 2023
Merged
Conversation
Author
|
I have switched from my own qmake build setup to cmake + FetchContent and this is the only thing that's breaking the build for iOS now. |
rgriebl
added a commit
to rgriebl/brickstore
that referenced
this pull request
Feb 22, 2023
Also converted it into a dynamic FetchContent dependency. Currently pulling from a fork until qcoro/qcoro#153 is resolved.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle QProcess missing on iOS in the same way Qt itself does: put all the QProcess related code inside a
#if QT_CONFIG(process)