Speed up rendering of planets example#7397
Merged
tkoyama010 merged 5 commits intomainfrom Apr 13, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7397 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 149 149
Lines 30618 30618
Branches 4015 4015
=======================================
Hits 29416 29416
Misses 571 571
Partials 631 631 |
Contributor
Contributor
Author
|
new execution time is 1m 30s instead of 4m |
MatthewFlamm
approved these changes
Apr 11, 2025
Contributor
MatthewFlamm
left a comment
There was a problem hiding this comment.
If anything the still images look even better than the originals.
krishanbhasin-px
pushed a commit
to krishanbhasin-px/pyvista
that referenced
this pull request
Apr 14, 2025
* Resample env tecture for planets example * Add files via upload --------- Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The planets example takes 4 minutes to render, even after #7357 was implemented.
This PR lowers the sampling resolution even more to speed it up.