Temporarily restrict NumPy version in pyproject.toml#6210
Merged
tkoyama010 merged 2 commits intopyvista:mainfrom Jun 6, 2024
Merged
Temporarily restrict NumPy version in pyproject.toml#6210tkoyama010 merged 2 commits intopyvista:mainfrom
tkoyama010 merged 2 commits intopyvista:mainfrom
Conversation
5 tasks
tkoyama010
approved these changes
Jun 5, 2024
Member
|
I will create a patch release on this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6210 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 141 141
Lines 25932 25932
=======================================
Hits 25178 25178
Misses 754 754 |
tkoyama010
pushed a commit
that referenced
this pull request
Jun 6, 2024
Co-authored-by: pyvista-bot <53544751+pyvista-bot@users.noreply.github.com>
Member
Author
|
Thanks, @tkoyama010! |
adeak
added a commit
to adeak/pyvista
that referenced
this pull request
Jun 6, 2024
Co-authored-by: pyvista-bot <53544751+pyvista-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We hope to fix all compatibility issues in #6156, but NumPy 2.0 is expected in 10 days and we should probably make sure that
maindoesn't break when NumPy 2.0 is released. Even though we'll only release when compatibility issues are fixed, excluding a dependency version that's known broken (just a bit) is good practice.My plan/proposal is:
mainfrom the NumPy 2.0 release until we're compatible