Fix image_threshold bug with integer arrays on some systems#6100
Merged
tkoyama010 merged 7 commits intopyvista:mainfrom May 19, 2024
Merged
Fix image_threshold bug with integer arrays on some systems#6100tkoyama010 merged 7 commits intopyvista:mainfrom
image_threshold bug with integer arrays on some systems#6100tkoyama010 merged 7 commits intopyvista:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6100 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 141 141
Lines 24624 24632 +8
=======================================
+ Hits 23884 23892 +8
Misses 740 740 |
Contributor
Author
|
From the failed tests it looks like it's a Linux and/or Python < 3.12 issue. The tests fail for some cases with integer inputs. |
image_threshold returns incorrect output (all zeros)image_threshold bug with integer arrays on some systems
tkoyama010
requested changes
May 19, 2024
5 tasks
tkoyama010
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Add image_threshold dtype tests * Validate filter input as float * Match paramater dtype to array dtype * Cast int arrays to float * Restrict casting to linux or mac or numpy < 2 * Fix casting back to input dtype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with
image_thresholdunexpectedly returning all zeros for integer scalar arrays. This seems to be build-specific. I am not able to reproduce this locally but the bug shows up in the docs.See images of the bug here #6071 (comment)