Skip to content

Add viewport parameter for add_text#390

Merged
banesullivan merged 2 commits intomasterfrom
add_text_normalized_viewport
Oct 4, 2019
Merged

Add viewport parameter for add_text#390
banesullivan merged 2 commits intomasterfrom
add_text_normalized_viewport

Conversation

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

Add a viewport parameter for the add_text() function of the BasePlotter to enable support for normalized viewport coordinates (values between 0 and 1 and support for HiDPI) if position is a tuple of floats.

@GuillaumeFavelier GuillaumeFavelier self-assigned this Oct 4, 2019
@GuillaumeFavelier GuillaumeFavelier added the enhancement Changes that enhance the library label Oct 4, 2019
@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

I called the parameter viewport but maybe something like normalized or normalized_position is better actually.

@banesullivan banesullivan merged commit ff23247 into master Oct 4, 2019
@banesullivan banesullivan deleted the add_text_normalized_viewport branch October 9, 2019 02:03
tkoyama010 pushed a commit that referenced this pull request Nov 12, 2024
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.2 → v0.7.3](astral-sh/ruff-pre-commit@v0.7.2...v0.7.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Changes that enhance the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants