Skip to content

Grab screenshot when plotter is closed#382

Merged
banesullivan merged 3 commits intomasterfrom
sphinx-patch
Oct 2, 2019
Merged

Grab screenshot when plotter is closed#382
banesullivan merged 3 commits intomasterfrom
sphinx-patch

Conversation

@banesullivan
Copy link
Copy Markdown
Member

This adds support for the BackgroundPlotter with sphinx-gallery

ping: @GuillaumeFavelier

I'm running into issues controlling the size of the window when using the BackgroundPlotter with sphinx gallery... its always super small

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

GuillaumeFavelier commented Sep 27, 2019

Thanks for this! I'll try the work on my end and see what happens.

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

I created a quick example bgplot.py and built the doc locally. So if I change the size before adding a mesh I obtain the following:

image

But if I change the window size after, I got an empty frame:

image

I will investigate further and meanwhile I whill push the example on this branch to share our results.

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

Nevermind, when I cleaned the cache inside docs/ with :

$ make clean
$ rm -r examples errors.txt images/auto_generated

and re-built everything:

$ make doctest
$ make html

Then it worked for me. What about you @banesullivan ?

Copy link
Copy Markdown
Contributor

@GuillaumeFavelier GuillaumeFavelier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! That way, even the BackgroundPlotter got a value for _last_image.

@banesullivan
Copy link
Copy Markdown
Member Author

I think this is good to go. All good from you @GuillaumeFavelier?

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

GuillaumeFavelier commented Oct 1, 2019

Yes It's all good for me. But I pushed the bgplot.py example just for testing purpose really, should we rework it first or get rid of it before merging?

@banesullivan
Copy link
Copy Markdown
Member Author

Let's get rid of that example and maybe add a better BackgroundPlotter example down the road to showcase the callback function to help users figure out how to use the BackgroundPlotter like in #387

@banesullivan
Copy link
Copy Markdown
Member Author

Thanks, @GuillaumeFavelier - once the tests pass, I'll merge

@banesullivan banesullivan merged commit 953227f into master Oct 2, 2019
@banesullivan banesullivan deleted the sphinx-patch branch October 9, 2019 02:03
tkoyama010 pushed a commit that referenced this pull request Nov 12, 2024
Bumps [trimesh](https://github.com/mikedh/trimesh) from 4.4.9 to 4.5.1.
- [Release notes](https://github.com/mikedh/trimesh/releases)
- [Commits](mikedh/trimesh@4.4.9...4.5.1)

---
updated-dependencies:
- dependency-name: trimesh
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants