Merged
Conversation
Member
Author
|
I set 4 as the default number of multi-samples but 8 is better... I've seen notes on forums/docs that 8 might be "slow" but I haven't noticed any performance issues so far (I have a high-end GPU and no way to test on more common/mid-grade GPUs) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 83.63% 83.60% -0.04%
==========================================
Files 33 33
Lines 7967 7989 +22
==========================================
+ Hits 6663 6679 +16
- Misses 1304 1310 +6 |
Member
Author
|
Pro tip: I have a system environment variable on my machine that sets the export PYVISTA_MULTI_SAMPLES=8 |
Merged
tkoyama010
pushed a commit
that referenced
this pull request
Nov 12, 2024
Bumps [adRise/update-pr-branch](https://github.com/adrise/update-pr-branch) from 0.9.0 to 0.9.1. - [Release notes](https://github.com/adrise/update-pr-branch/releases) - [Commits](adRise/update-pr-branch@v0.9.0...v0.9.1) --- updated-dependencies: - dependency-name: adRise/update-pr-branch dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a way to control the anti-aliasing features in the
vtkRenderWindow. I added options for controlling the point, line, and polygon smoothing (not sure if these really do anything, but I know they have to be called before the first render) and I added a convenient way to set the number of multi-samples used to avoid aliasing.I'm not exactly sure if this will have any performance implications or issues across operating systems.
Examples
The aliasing was most notable on axes grid lines/text and on the edges of meshes.
Make sure to zoom into or download these PNGs if you want to compare - your web browser is likely affecting how they look!!!
Axes Grid
Current behavior - 0 multi-samples:
New default - 4 multi-samples:
And 8 multi-samples because why not:
Edges on a Mesh
Current behavior - 0 multi-samples:
New default - 4 multi-samples:
And 8 multi-samples because why not: