Merged
Conversation
bhavya01
approved these changes
Sep 24, 2025
Collaborator
Author
Right, we don't depend on fmtlib, and Pytorch does. However, we are defining the bazel target for PyTorch by specifying a build rule, and the build rule is controlled by us but considers as "Pytorch's build rule". Note that pytorch also have their own bazel target (as they support bazel build: https://github.com/pytorch/pytorch/blob/main/BUILD.bazel) but instead of we depending on that, we created another bazel target for Pytorch by referring to their .so file (which is built by CMake) and headers. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 30, 2025
`fmtlib` version was updated to 12.0.0 in #163441. In this new version, due to fmtlib/fmt#4536, PyTorch started not installing `fmtlib` headers anymore. Because of that, PyTorch/XLA build CI started to fail pytorch/xla#9653. While we did fix it internally pytorch/xla#9650, I believe that PyTorch should continue installing the `fmtlib` headers, since it is a dependency of its C API [`python_arg_parser.h`][1]. PyTorch/XLA CI was moved to `unstable.yml` in #159272, and later removed in #163564. This PyTorch/XLA build failure went under the radar, since the `fmtlib` update only landed on September 22. [1]: https://github.com/pytorch/pytorch/blob/84d673ef577d42d6ec20c6c9f09863583c3111f5/torch/csrc/utils/python_arg_parser.h#L42 Pull Request resolved: #164139 Approved by: https://github.com/Skylion007, https://github.com/malfet
ysiraichi
added a commit
that referenced
this pull request
Nov 6, 2025
This PR removes the temporary fmtlib dependency introduced in #9650 (see issue #9653). As explained [in this comment][1], the dependency was only added to work around a build issue that should have been fixed upstream in PyTorch. Before the `fmtlib` version bump to 12 in PyTorch (pytorch/pytorch#163441), `fmtlib` headers were exported by default. After the bump, they stopped being exported, which caused the issue. That behavior has since been fixed in PyTorch (pytorch/pytorch#164139), so we can safely remove the explicit fmtlib dependency. [1]: #9650 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.