Error Handling: return status value when loading PjRt dynamic plugin.#9495
Merged
Error Handling: return status value when loading PjRt dynamic plugin.#9495
Conversation
b11ece5 to
05ebba9
Compare
ghpvnist
approved these changes
Jul 21, 2025
zhanyong-wan
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error handling for
PjRtPluginandComputationClientinitialization. It provides better error messages and prevents repeated error reporting. A new test has been added for dynamicPjRtPluginregistration error.Key Changes
GetPjRtPlugin()function returns aFailedPreconditionError()if noPjRtPluginwas registered to the currentPJRT_DEVICEwith a better error messageg_computation_client_initializedvariable is only set if theComputationClientis successfully initialized_XLAC._prepare_to_exit()functionStatusOr<T>value inGetComputationClientOrDie()function by usingGetValueOrThrow()function, instead of.value()Bad StatusOr access: INVALID_ARGUMENTPjRtPlugin