Dump C++ and Status propagation stacktraces.#9492
Merged
Conversation
zhanyong-wan
requested changes
Jul 22, 2025
ghpvnist
requested changes
Jul 22, 2025
ec39b02 to
5b0aaf4
Compare
zhanyong-wan
approved these changes
Jul 28, 2025
5b0aaf4 to
e0427a2
Compare
Collaborator
Author
|
@ghpvnist I have addressed your comments. Let me know if there's anything else you'd like to see in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the discussion in #9339 by enhancing error reporting with C++ and Status propagation stack traces. The main goal is to provide more informative error messages by including both C++ stacktraces and Status propagation stacktraces. This should help developers quickly pinpoint error origins and understand how errors propagate through the system, simplifying debugging.
Key Changes:
MaybeWithLocationandMaybeWithNewMessageto thestatus_internalnamespace, as they are intended for internal use only.Statuspayload for separate storage of the status propagation stacktrace.tsl::CurrentStackTrace()immediately before throwing an exception.test_status_common.hto reflect these changes.MaybeThrowWithErrorPropagationWithNewMessage, to demonstrate the format of the enhanced error messages.test_status_common.hto adhere to thekVarNamepattern.Update: added the function name
__FUNCTION__to the status propagation trace. Lambda functions are recorded asoperator().Before:
After: