9082 educate users on mat mul precision#9103
Merged
Conversation
…on-mat-mul-precision
Collaborator
Author
|
PDF of doc is here |
…on-mat-mul-precision
…on-mat-mul-precision
…on-mat-mul-precision
…hub.com/pytorch/xla into 9082-educate-users-on-mat-mul-precision
tengyifei
reviewed
May 9, 2025
tengyifei
reviewed
May 9, 2025
tengyifei
approved these changes
May 10, 2025
Collaborator
tengyifei
left a comment
There was a problem hiding this comment.
Thanks! I really enjoyed reading it.
Collaborator
Author
|
Added logger.warning, added issue on examples I saw of logging.warning instead of logging.get_logger.warning, added unit test to assert the warning message, and consumed the warning message in all other unit tests to avoid polluting the unit test harness stdout. |
tengyifei
approved these changes
May 12, 2025
qihqi
approved these changes
May 15, 2025
Collaborator
Author
|
I discussed w/ Mike Green off-line. Okay to merge now, he will open any issues for follow-up work. |
This was referenced May 19, 2025
pgmoka
pushed a commit
that referenced
this pull request
May 29, 2025
cicd test for doc build was disabled. Will monitor post commit cicd for doc success, because this PR does change the doc build scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds runnable tutorial to teach users about mat mul precision.
Also includes new manual build instructions for runnable tutorials.