Fix the source param sharding for GradAcc API#8999
Merged
tengyifei merged 1 commit intopytorch:masterfrom Apr 17, 2025
Merged
Conversation
Collaborator
Author
|
@tengyifei PTAL, easiest PR :) |
tengyifei
approved these changes
Apr 17, 2025
rpsilva-aws
added a commit
that referenced
this pull request
Apr 17, 2025
zpcore
pushed a commit
that referenced
this pull request
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explains the recent nuances with the observed memory footprint model initialization, small fix.