Skip to content

fix CPP test build failure in upstream#8867

Merged
tengyifei merged 1 commit intomasterfrom
piz/fix_dep
Mar 21, 2025
Merged

fix CPP test build failure in upstream#8867
tengyifei merged 1 commit intomasterfrom
piz/fix_dep

Conversation

@zpcore
Copy link
Copy Markdown
Member

@zpcore zpcore commented Mar 20, 2025

PyTorch CI cpp test build failed with the following error:

[0m/var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:429:8: Compiling torch_xla/csrc/runtime/util_test.cc failed: undeclared inclusion(s) in rule '//torch_xla/csrc/runtime:util_test':this rule is missing dependency declarations for the following files included by 'torch_xla/csrc/runtime/util_test.cc':  'external/tsl/tsl/platform/errors.h'

Failure link.

One thing I don't understand is that why the failure is not happening in our side. Make the fix to quickly unblock PyTorch CI.

@zpcore zpcore marked this pull request as ready for review March 20, 2025 22:13
@zpcore zpcore requested review from lsy323 and tengyifei March 20, 2025 22:13
@tengyifei tengyifei merged commit 760675a into master Mar 21, 2025
@zpcore zpcore deleted the piz/fix_dep branch March 21, 2025 03:09
zpcore added a commit that referenced this pull request Mar 26, 2025
zpcore added a commit that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants