Skip to content

Add lowering for bitwise_right_shift.#8866

Merged
ysiraichi merged 3 commits intomasterfrom
ysiraichi/lower-right-shift
Mar 24, 2025
Merged

Add lowering for bitwise_right_shift.#8866
ysiraichi merged 3 commits intomasterfrom
ysiraichi/lower-right-shift

Conversation

@ysiraichi
Copy link
Copy Markdown
Collaborator

This PR lowers torch.bitwise_right_shift operation. It introduces the following changes:

  • Add bitwise_right_shift.Tensor to full_codegen section of native_functions.yaml
  • Introduce the corresponding *OuputShape() and *::Lower() functions
  • Add test confirming that we don't fallback

@ysiraichi ysiraichi added the lowering ATen Operation lowering label Mar 20, 2025
@ysiraichi ysiraichi requested review from pgmoka and tengyifei March 20, 2025 18:54
@ysiraichi ysiraichi added the DO_NOT_MERGE Not for merging. label Mar 20, 2025
@ysiraichi
Copy link
Copy Markdown
Collaborator Author

This PR should be merged after #8865.

@ysiraichi ysiraichi changed the base branch from master to ysiraichi/lower-left-shift March 20, 2025 18:55
@ysiraichi ysiraichi force-pushed the ysiraichi/lower-right-shift branch from 787f4a7 to 057300a Compare March 20, 2025 23:37
@ysiraichi ysiraichi changed the base branch from ysiraichi/lower-left-shift to master March 24, 2025 17:05
@ysiraichi ysiraichi force-pushed the ysiraichi/lower-right-shift branch from 057300a to f5b4606 Compare March 24, 2025 17:11
@ysiraichi
Copy link
Copy Markdown
Collaborator Author

Rebased. Waiting for CI.

@mikegre-google mikegre-google removed their request for review March 24, 2025 17:13
@ysiraichi ysiraichi merged commit 2aa11cc into master Mar 24, 2025
22 checks passed
@ysiraichi ysiraichi removed the DO_NOT_MERGE Not for merging. label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lowering ATen Operation lowering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants