Add lowering for bitwise_left_shift.#8865
Merged
Conversation
tengyifei
approved these changes
Mar 20, 2025
pgmoka
reviewed
Mar 20, 2025
Collaborator
pgmoka
left a comment
There was a problem hiding this comment.
Could you add a link to https://github.com/pytorch/xla/blob/master/docs/source/contribute/codegen_migration.md as potential reference for what was done here?
Also, I had one question I was curious about. Depending on that, there might be changes I would suggest.
pgmoka
approved these changes
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lowers
torch.bitwise_left_shiftoperation. It introduces the following changes:bitwise_left_shift.Tensortofull_codegensection of native_functions.yaml*OuputShape()and*::Lower()functions